Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: alphagov/notifications-node-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.0.6
Choose a base ref
...
head repository: alphagov/notifications-node-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.0.0
Choose a head ref
  • 9 commits
  • 7 files changed
  • 3 contributors

Commits on Dec 8, 2023

  1. Guidance for adding bullet points in personalisation

    @CrystalPea
    CrystalPea authored Dec 8, 2023
    Copy the full SHA
    ea64d6e View commit details

  2. Use "array" instead of list, as this is the javascript way

    @CrystalPea
    CrystalPea authored Dec 8, 2023
    Copy the full SHA
    1105f00 View commit details

Commits on Dec 14, 2023

  1. Get rid of trailing comas to please the linter

    @CrystalPea
    CrystalPea authored Dec 14, 2023
    Copy the full SHA
    02a9890 View commit details

  2. Merge pull request #192 from alphagov/bullet-points-in-personalisation 

    Guidance for adding bullet points in personalisation
    @CrystalPea
    CrystalPea authored Dec 14, 2023
    Copy the full SHA
    6e35ed0 View commit details

Commits on Jan 4, 2024

  1. Remove DOCUMENTATION.md from client repository 

    It now lives in notifications-tech-docs repository,
along with other client docs.
    @CrystalPea
    CrystalPea committed Jan 4, 2024
    Copy the full SHA
    e446738 View commit details

  2. Add a link to node docs in tech-docs repo 

    To make it easier for future contributors.
    @CrystalPea
    CrystalPea authored Jan 4, 2024
    Copy the full SHA
    20e763d View commit details

  3. Merge pull request #194 from alphagov/move-documentation-to-tech-docs 

    Remove DOCUMENTATION.md from client repository
    @CrystalPea
    CrystalPea authored Jan 4, 2024
    Copy the full SHA
    a3e8d4c View commit details

  4. Allow setting custom filenames for documents 

    Update client for the new document download feature which allows
specifying a download filename for files sent by email.

This supercedes the old `isCsv` parameter that was inconsistent at best.

Given this, we are dropping support for `isCsv` altogether which lets us
clean up the interface for the `prepareUpload` function to now only use
the new options dict.
    @samuelhwilliams
    samuelhwilliams committed Jan 4, 2024
    Copy the full SHA
    74f3bd6 View commit details

Commits on Jan 5, 2024

  1. Merge pull request #193 from alphagov/SW-custom-filename 

    Allow setting custom filenames for documents
    @samuelhwilliams
    samuelhwilliams authored Jan 5, 2024
    Copy the full SHA
    ff948ad View commit details
Showing with 33 additions and 1,358 deletions.
  1. +1 −1 .github/PULL_REQUEST_TEMPLATE.md
  2. +7 −0 CHANGELOG.md
  3. +0 −1,284 DOCUMENTATION.md
  4. +5 −13 client/notification.js
  5. +2 −2 package-lock.json
  6. +1 −1 package.json
  7. +17 −57 spec/notification.js
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
- [x] I’ve used the pull request template
- [ ] I’ve written unit tests for these changes
- [ ] I’ve updated the documentation in
- `DOCUMENTATION.md`
- [notifications-tech-docs repository](https://github.com/alphagov/notifications-tech-docs/blob/main/source/documentation/client_docs/_node.md)
- `CHANGELOG.md`
- [ ] I’ve bumped the version number in
- `package.json`
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 8.0.0 - 2023-12-27

* Remove the default `is_csv` boolean parameter from `prepareUpload`. This method now accepts a file and an options map with the following options. For more specific information please read the documentation.
* `filename` (string) - specify the document's filename upon download
* `confirm_email_before_download` (boolean) - require the user to enter their email address before the file can be downloaded.
* `retention_period` (string) - how long Notify should make the file available to the user for.

## 7.0.6 - 2023-11-13

* Bump axios from 1.2.6 to 1.6.1
Loading