Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min-width from share links flexbox variant list-items #4488

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

KludgeKML
Copy link
Contributor

@KludgeKML KludgeKML commented Dec 10, 2024

What

Remove min-width from share links flexbox variant list-items

Why

Current share items look odd with very small text content (eg X)

Visual Changes

(screenshots from frontend, but also compare: https://components.publishing.service.gov.uk/component-guide/share_links/with_flexbox/preview with https://components-gem-pr-4488.herokuapp.com/component-guide/share_links/with_flexbox/preview)

Before

Screenshot 2024-12-10 at 15 00 44

After

Screenshot 2024-12-10 at 11 47 46

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4488 December 10, 2024 15:01 Inactive
@KludgeKML KludgeKML force-pushed the pfc-share-links-tweak branch from 95de5c7 to 57e4642 Compare December 10, 2024 15:02
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4488 December 10, 2024 15:02 Inactive
@KludgeKML KludgeKML force-pushed the pfc-share-links-tweak branch from 57e4642 to c631bf7 Compare December 10, 2024 15:15
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4488 December 10, 2024 15:16 Inactive
@KludgeKML KludgeKML force-pushed the pfc-share-links-tweak branch from c631bf7 to 2f28d16 Compare December 10, 2024 15:17
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4488 December 10, 2024 15:17 Inactive
- retain 100% min-width on mobile
@KludgeKML KludgeKML force-pushed the pfc-share-links-tweak branch from 2f28d16 to c53cdde Compare December 10, 2024 16:16
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4488 December 10, 2024 16:16 Inactive
@KludgeKML KludgeKML merged commit 56040ed into main Dec 10, 2024
12 checks passed
@KludgeKML KludgeKML deleted the pfc-share-links-tweak branch December 10, 2024 16:23
@KludgeKML KludgeKML mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants