Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popular links in search header #3904

Merged
merged 2 commits into from Mar 6, 2024
Merged

Conversation

hannako
Copy link
Contributor

@hannako hannako commented Mar 5, 2024

What

Update popular links in the search in the header to match those on the body of the page, as defined in https://github.com/alphagov/frontend/blob/main/config/locales/en.yml#L572-L584

Why

Both parts of the page should contain the same links. These were missed from alphagov/frontend#3524

Visual Changes

Before After
Screenshot 2024-03-05 at 20 39 20 Screenshot 2024-03-05 at 21 25 56

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3904 March 5, 2024 21:26 Inactive
@hannako hannako marked this pull request as ready for review March 5, 2024 21:28
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3904 March 5, 2024 21:28 Inactive
Copy link
Contributor

@maxgds maxgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although we really should prioritise making this an update-once thing, I reckon.

@hannako hannako merged commit 866ca15 into main Mar 6, 2024
12 checks passed
@hannako hannako deleted the udpate_popular_links_in_search branch March 6, 2024 09:55
@andysellick andysellick mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants