Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie settings page crash in IE11 #3894

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Mar 1, 2024

What

Why

  • /help/cookies is crashing when saving the form in production in IE11

Visual Changes

None

@AshGDS AshGDS requested a review from andysellick March 1, 2024 11:47
@AshGDS AshGDS self-assigned this Mar 1, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3894 March 1, 2024 11:47 Inactive
URL is unsupported in IE11, so use try/catch for this value
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3894 March 4, 2024 14:01 Inactive
@AshGDS AshGDS merged commit 9f02f4a into main Mar 4, 2024
12 checks passed
@AshGDS AshGDS deleted the fix-cookie-settings-ie11 branch March 4, 2024 14:04
@andysellick andysellick mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants