Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GA4 callout tracking from govspeak component #3889

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Feb 28, 2024

What

  • Remove callout link tracking from govspeak component

Why

  • Due to how our tracking is architected, adding this tracking removed some external link tracking that we think is higher priority to track. Therefore disable tracking while we come up with a fix.

Visual Changes

Removed example from .yml

@AshGDS AshGDS self-assigned this Feb 28, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3889 February 28, 2024 15:17 Inactive
@AshGDS AshGDS force-pushed the ga4-remove-govspeak-tracking branch from 94bf618 to 7e742fb Compare February 28, 2024 15:18
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3889 February 28, 2024 15:18 Inactive
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine, one minor question.

@@ -46,15 +46,4 @@ def component_name

expect(rendered).to include("content-via-block")
end

it "adds GA4 link tracking" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there was no test to test the disable_ga4 flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andysellick Yep, realised this was missed while removing the code 😓

@AshGDS AshGDS merged commit df0f000 into main Feb 28, 2024
12 checks passed
@AshGDS AshGDS deleted the ga4-remove-govspeak-tracking branch February 28, 2024 15:32
@AshGDS AshGDS mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants