Revert "Add GOVUK domains to script src CSP" #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b30410c. We thought it would solve a CORS issue, but it did not so we don't need this change.
ChrisBAshton
approved these changes
Dec 21, 2023
lib/govuk_app_config/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module GovukAppConfig | |||
| VERSION = "9.8.0".freeze | |||
| VERSION = "9.9.0".freeze | |||
There was a problem hiding this comment.
Nitpick: we could make this 9.8.1, because it's not a breaking change (insofar as no other apps will have made any changes in light of the change introduced in 9.8.0) and it's more of a bugfix than a new feature.
There was a problem hiding this comment.
Thanks @ChrisBAshton, will update 👍
AshGDS
force-pushed
the
revert-csp-change-ash
branch
from
a3a221b
to
1416331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b30410c.
We thought it would solve a CORS issue, but it did not so we don't need this change.