Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GOVUK domains to script src CSP #334

Merged
merged 2 commits into from Dec 20, 2023
Merged

Add GOVUK domains to script src CSP #334

merged 2 commits into from Dec 20, 2023

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Dec 20, 2023 •
edited

The assets.publishing.service.gov.uk domain can't POST to the feedback form without this, so users can't report problems with our CSV preview pages.

@AshGDS
Add GOVUK domains to script src CSP
b30410c 
The assets domain can't POST to the feedback form without this.
@AshGDS AshGDS self-assigned this Dec 20, 2023
AgaDufrat
AgaDufrat approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@AgaDufrat AgaDufrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Feel free to release the gem in the same PR.

@AshGDS AshGDS merged commit bba0e4b into main Dec 20, 2023
9 checks passed
@AshGDS AshGDS deleted the add-assets-domain-to-script-csp branch December 20, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgaDufrat AgaDufrat AgaDufrat approved these changes

Assignees

@AshGDS AshGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AshGDS @AgaDufrat