Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAVE accessibility tool alerting on <details> styling #4852

Open
wilsond-gds opened this issue Mar 11, 2024 · 1 comment
Open

WAVE accessibility tool alerting on <details> styling #4852

wilsond-gds opened this issue Mar 11, 2024 · 1 comment
Labels
accessibility accessibility-concern Any bug, feature request or question about the accessibility of a portion of a product. awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@wilsond-gds
Copy link

Description of the issue

Pages using the details component will cause an unexpected alert in the Wave accessibility evalution tool as of 11th March 2024.

Steps to reproduce the issue

Run the Wave checker on any page using a details component. The tool will create an Underlined text alert for each use of the summary tag. Wave is probably picking up the underline from the CSS that styles the summary text span.

.govuk-details__summary-text {
    text-decoration: underline;
}

Screenshot of unexpected Wave tool

Actual vs expected behaviour

This is a very small issue which is easily cleared up by checking the source code, but may cause problems if we advocate for developers to run automated tests before committing code to a repository.

Environment (where applicable)

  • Operating system: MacOS
  • Browser: Chrome
  • GOV.UK Frontend Version: 4.8.0
@wilsond-gds wilsond-gds added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) awaiting triage Needs triaging by team labels Mar 11, 2024
@domoscargin domoscargin added accessibility accessibility-concern Any bug, feature request or question about the accessibility of a portion of a product. labels Mar 11, 2024
@36degrees
Copy link
Member

This appears as an alert in WAVE.

WAVE's 'reference' (contextual help) says:

What It Means

Underlined text is present.

Why It Matters

Underlines almost universally indicates linked text. Consider removing the underline from the non-link text. Other styling (e.g., bold or italics) can be used to differentiate the text.

How to Fix It

Unless there is a distinct need for the underlined text, remove the underline from it.

The Algorithm... in English

A <u> element or element with text-decoration:underline styles is present.

Standards and Guidelines

None

Given we're intentionally styling it similarly to a link to make it appear interactive, I don't think this is something we're likely to want to change?

I've added it to our 'known issues' project so that other WAVE users might be able to find this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility accessibility-concern Any bug, feature request or question about the accessibility of a portion of a product. awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Development

No branches or pull requests

3 participants