Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use the phase banner without a phase tag #4827

Open
2 tasks
36degrees opened this issue Mar 6, 2024 · 1 comment
Open
2 tasks

Make it possible to use the phase banner without a phase tag #4827

36degrees opened this issue Mar 6, 2024 · 1 comment

Comments

@36degrees
Copy link
Member

36degrees commented Mar 6, 2024

What

Make it possible to use the phase banner macro without a phase tag by:

  • not outputting an empty tag when no tag is passed
  • marking the tag option as not required in the macro options
  • adding an example
  • adding tests to cover this behaviour
  • ensuring we're happy with the design and layout of the phase banner when no tag is included

Why

We're seeing examples of this in live services:

Screenshot of a phase banner from a live service. The phase banner does not have a phase tag. It includes the text 'Your feedback (opens in new tab) will help us improve the service'.

It's a bit strange given that this component is called a phase banner, and there are questions about whether the phase banner is the right place to ask for feedback, but this is an easy change to match how the component is being used in some places.

Adding an example of this also means we'll consider this use case when making changes to the component, avoiding accidental breaking changes for instances where there is no phase tag being used.

Because we're not sure this is the right place to ask for feedback, I suggest we don't add guidance or examples to the Design System for now.

Who needs to work on this

Developers, designer

Who needs to review this

Developers, designer

Done when

  • The phase banner can be used without a phase tag
  • We have an example and tests to cover this behaviour

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant