Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Sass workflows against built sass files rather than sources. #4804

Open
1 task
romaricpascal opened this issue Feb 26, 2024 · 0 comments
Open
1 task

Comments

@romaricpascal
Copy link
Member

What

Update our Sass workflows so they run against the build Sass files (in packages/govuk-frontend/dist) rather than the sources as they do now.

This would likely require to update when the workflow runs so it executes after the build has been done and cached (similarly to running Percy), to avoid building the project multiple times.

Why

This will ensure that they run against the code our users will be importing, which is not quite the same as the sources as PostCSS and Autoprefixer will have run, updating the code and adding sourcemaps.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Sass workflows run against the built package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant