Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice about supported Preact versions in README #678

Merged
merged 1 commit into from Mar 11, 2024

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Mar 1, 2024

#677 (not to be merged) provides the branch testing against Preact 10.19.6, which showed a single automated test failing in IE11.

This commits adds a notice to the README to clarify which versions of Preact were tested and the result, in a similar fashion to the section for React.

Closes #667

@romaricpascal romaricpascal marked this pull request as draft March 1, 2024 16:13
@romaricpascal
Copy link
Member Author

Converting back to draft while I re-check the results.

@romaricpascal romaricpascal linked an issue Mar 11, 2024 that may be closed by this pull request
1 task
@romaricpascal romaricpascal marked this pull request as ready for review March 11, 2024 12:30
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound!

Base automatically changed from bind-input-click to main March 11, 2024 15:27
@romaricpascal romaricpascal merged commit c8bcf31 into main Mar 11, 2024
3 checks passed
@romaricpascal romaricpascal deleted the preact-versions-notice branch March 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run test against latest version 10.x of Preact
2 participants