Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of changes since last release in the CHANGELOG #662

Merged
merged 1 commit into from Mar 5, 2024

Conversation

romaricpascal
Copy link
Member

I think I collected all the revelant pull requests merged since the last release.

Closes #624.

- [Pull request #496: Handle query change when the text length does not change](https://github.com/alphagov/accessible-autocomplete/pull/496) (merged through [pull request #621](https://github.com/alphagov/accessible-autocomplete/pull/621)). Thanks to @archferns for contributing this change.
- [Pull request #591: Add `menuAttributes` to fix Axe's 'aria-input-field-name' error](https://github.com/alphagov/accessible-autocomplete/pull/591). Thanks to @mchughbri for contributing this change.
- [Pull request #600: Fix null aria attributes](https://github.com/alphagov/accessible-autocomplete/pull/600). Thanks to @mark-roberts-ho for contributing this change.
- [Pull request #606: Correct description of tStatusSelectedOption i18n option in README and tweak some wording for consistency with other parts of the README](https://github.com/alphagov/accessible-autocomplete/pull/606). Thanks to @ellamdav for contributing this change.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a docs fix, rather than a code fix, but it felt important to acknowledge that kind of contribution as well.

CHANGELOG.md Outdated Show resolved Hide resolved
@romaricpascal romaricpascal marked this pull request as ready for review February 22, 2024 12:04
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: CAAshworth <claire.ashworth@digital.cabinet-office.gov.uk>
@romaricpascal
Copy link
Member Author

@claireashworth Looks like I missed a couple of things for the breaking changes, sorry:

  • the PRs leading to the polyfill breaking change (thanks @colinrotherham for making me notice, do other PRs need to be added for that one?)
  • the PR for the changes of styles which may lead to services needing to do some minor CSS tweaks (so I've put it in breaking)

Would you be able to give another look, please? 😊

@romaricpascal romaricpascal merged commit 23c90ee into main Mar 5, 2024
3 checks passed
@romaricpascal romaricpascal deleted the changelog-update branch March 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalise CHANGELOG content ahead of release
3 participants