Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null aria attributes #600

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

mark-roberts-ho
Copy link
Contributor

@mark-roberts-ho mark-roberts-ho commented Sep 26, 2023

This is a fix for #434

The implementation prevents false aria values from being included.

I have also changed the build command, removing the single quotes which do not work in my environment.

Please let me know who is responsible for version number increments in package.json

@romaricpascal
Copy link
Member

romaricpascal commented Jan 12, 2024

Hi @mark-roberts-ho , thanks for the fix! Regarding the version number increment, this is something we'll change when we release the next version of the package, so no need to worry about it.

Looks like GitHub is struggling to trigger its workflows, though. Would you be able to force push your branch with a new SHA for that last commit to see if GitHub, please? I think git commit --amend -C HEAD should give your commit a new SHA which you can force push with git push --force-with-lease 😊 If GitHub lets me, I'm also happy to do it if you prefer.

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-roberts-ho Our merges of a couple of PRs lately has brought quite a few conflicts, so I'll try to rebase your branch so it can be merged, as the code looks neat! Thanks for the contribution.

@romaricpascal romaricpascal merged commit 7781d8e into alphagov:main Jan 15, 2024
3 checks passed
@romaricpascal romaricpascal mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants