Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consensus): TxEnvelope generic over Eip4844 #2169

Merged
merged 10 commits into from
Mar 10, 2025
Merged

feat(consensus): TxEnvelope generic over Eip4844 #2169

merged 10 commits into from
Mar 10, 2025
+208 −609

Conversation

Rimeeeeee
Copy link
Contributor

@Rimeeeeee Rimeeeeee commented Mar 8, 2025 •
edited by yash-atreya
Loading

Closes #2163

@Rimeeeeee
Copy link
Contributor Author

Rimeeeeee commented Mar 8, 2025 •
edited
Loading

i have tried to address the changes in TxEnvelope->EthereumTxEnvelope<Eip4844> but there are certain errors regarding Signed<Eip4844> ( declared inside enum) .Can you help me to fix those? @klkvr @mattsse

mattsse
mattsse previously requested changes Mar 8, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

smol nit

@Rimeeeeee
Copy link
Contributor Author

Rimeeeeee commented Mar 8, 2025 •
edited
Loading

ty

smol nit

i have done that..but there are some issues when dealing with Signed<Eip4844> in serde and impls...kindly look into it. @mattsse

@yash-atreya yash-atreya changed the title tried TxEnvelope fixes feat(consensus): TxEnvelope generic over Eip4844 Mar 10, 2025
klkvr and others added 5 commits March 10, 2025 16:39
@klkvr
fix bounds
Loading
Loading status checks…
dc7a76a
@Rimeeeeee
Merge branch 'main' into envelope-eip4844
2a53e82
@klkvr
fix lint

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
6decaad
@klkvr
fix lint

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1c23b9f
@klkvr
fix bound
Loading
Loading status checks…
c9ded9d
@Rimeeeeee Rimeeeeee requested a review from mattsse March 10, 2025 15:36
klkvr added 2 commits March 10, 2025 21:19
@klkvr
Hash
12ef79a
@klkvr
add fn hash()
Loading
Loading status checks…
7945d29
klkvr
klkvr approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@klkvr klkvr enabled auto-merge (squash) March 10, 2025 20:40
@klkvr klkvr merged commit 582da47 into alloy-rs:main Mar 10, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr

@DaniPopes DaniPopes

@gakonst gakonst

@onbjerg onbjerg

@mattsse mattsse

Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Make TxEnvelope generic over Eip4844 variant
3 participants
@Rimeeeeee @mattsse @klkvr