client_alert.go

@@ -155,28 +155,37 @@ type SinkAlerthubConfiguration struct {
 }
 
 type Alert struct {
-	Name             string              `json:"name"`
-	DisplayName      string              `json:"displayName"`
-	Description      string              `json:"description"`
-	State            string              `json:"state"`
-	Status           string              `json:"status"`
+	Name        string `json:"name"`
+	DisplayName string `json:"displayName"`
+	Description string `json:"description"`
+	// Deprecated: use `alert.IsEnabled()` to get the status, use api EnableAlert and DisableAlert to enable/disable the alert
+	State            string              `json:"state,omitempty"`
+	Status           string              `json:"status,omitempty"`
 	Configuration    *AlertConfiguration `json:"configuration"`
 	Schedule         *Schedule           `json:"schedule"`
 	CreateTime       int64               `json:"createTime,omitempty"`
 	LastModifiedTime int64               `json:"lastModifiedTime,omitempty"`
 }
 
+func (alert *Alert) IsEnabled() bool {
+	return alert.Status == "ENABLED"
+}
+
 func (alert *Alert) MarshalJSON() ([]byte, error) {
 	body := map[string]interface{}{
 		"name":          alert.Name,
 		"displayName":   alert.DisplayName,
 		"description":   alert.Description,
-		"state":         alert.State,
-		"status":        alert.Status,
 		"configuration": alert.Configuration,
 		"schedule":      alert.Schedule,
 		"type":          "Alert",
 	}
+	if alert.State != "" {
+		body["state"] = alert.State
+	}
+	if alert.Status != "" {
+		body["status"] = alert.Status
+	}
 	return json.Marshal(body)
 }
 

client_alert_test.go

@@ -74,7 +74,6 @@ func (s *AlertTestSuite) createAlert() error {
 	}
 	alert := &Alert{
 		Name:        s.alertName,
-		State:       "Enabled",
 		DisplayName: "AlertTest By GO SDK",
 		Description: "Description for alert",
 		Schedule: &Schedule{
@@ -130,7 +129,6 @@ func (s *AlertTestSuite) createAlert2() error {
 	}
 	alert := &Alert{
 		Name:        s.alertName,
-		State:       "Enabled",
 		DisplayName: "AlertTest By GO SDK ",
 		Description: "Description for alert by go sdk",
 		Schedule: &Schedule{
@@ -303,12 +301,12 @@ func (s *AlertTestSuite) TestClient_DisableAndEnableAlert() {
 	s.Require().Nil(err)
 	alert, err := s.client.GetAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
-	s.Require().Equal("Disabled", alert.State, "disable alert failed")
+	s.Require().False(alert.IsEnabled(), "disable alert failed")
 	err = s.client.EnableAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
 	alert, err = s.client.GetAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
-	s.Require().Equal("Enabled", alert.State, "enable alert failed")
+	s.Require().True(alert.IsEnabled(), "enable alert failed")
 	err = s.client.DeleteAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
 }
@@ -320,12 +318,12 @@ func (s *AlertTestSuite) TestClient_DisableAndEnableAlert2() {
 	s.Require().Nil(err)
 	alert, err := s.client.GetAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
-	s.Require().Equal("Disabled", alert.State, "disable alert failed")
+	s.Require().False(alert.IsEnabled(), "disable alert failed")
 	err = s.client.EnableAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
 	alert, err = s.client.GetAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
-	s.Require().Equal("Enabled", alert.State, "enable alert failed")
+	s.Require().True(alert.IsEnabled(), "enable alert failed")
 	err = s.client.DeleteAlert(s.projectName, s.alertName)
 	s.Require().Nil(err)
 }

example/alert/alert_example.go

@@ -53,8 +53,6 @@ func main() {
 		Name:        alertName,
 		DisplayName: "count monitoring",
 		Description: "",
-		State:       "Enabled",
-		Status:      "",
 		Configuration: &sls.AlertConfiguration{
 			Condition: "count > 0",
 			Dashboard: dashboardName,