Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console通知面板在英文界面仍然显示中文 #11706

Closed
lcmarvin opened this issue Jan 26, 2024 · 7 comments · Fixed by #11729
Closed

Console通知面板在英文界面仍然显示中文 #11706

lcmarvin opened this issue Jan 26, 2024 · 7 comments · Fixed by #11729
Labels

Comments

@lcmarvin
Copy link
Contributor

如下图所示:

image
@Daydreamer-ia
Copy link
Contributor

pr welcome

@lcmarvin
Copy link
Contributor Author

pr welcome

Notice的具体内容是通过接口/v1/console/server/announcement获取到的,需要在点击中英文切换时再次请求接口吗?这样的话接口需要带上当前语言参数。或者具体内容不通过接口获取,直接放到console-ui里,就可以用已有的方式实现中英文切换。

不太清楚出于什么考虑,Notice的具体内容需要从接口获取。

@KomachiSion
Copy link
Collaborator

Notice的内容根据不同的环境,部署人员可以修改,如果写死在ui中,修改需要编译,不是很合适。

由于内容是可以修改的, 如果有必要可以通过announcement文件修改为双语内容。

@lcmarvin
Copy link
Contributor Author

lcmarvin commented Feb 4, 2024

#11729 尝试修复该问题,但点击中英文切换按钮后,需刷新页面才生效,不知该思路是否合适?

@985492783
Copy link
Contributor

#11729 尝试修复该问题,但点击中英文切换按钮后,需刷新页面才生效,不知该思路是否合适?

我觉得后台可以直接改成英文,就目前来说,nacos-server并没有国际化,所有国际化都在前端做的,感觉没必要因为一个公告接口做这个事情 @KomachiSion

@KomachiSion
Copy link
Collaborator

接口的目的不在于国际化,而在于提示内容的自定义,不能前段写死, 必须通过接口内容返回,至于接口的实现可以变更,用于实现国际化。

lcmarvin added a commit to lcmarvin/nacos that referenced this issue Feb 23, 2024
lcmarvin added a commit to lcmarvin/nacos that referenced this issue Feb 23, 2024
@lcmarvin
Copy link
Contributor Author

console-guide.conf 应该有同样的问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants