Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The thread created by the thread pool lacks the auto-increment serial number #11612

Closed
zhongqishang opened this issue Jan 9, 2024 · 1 comment · Fixed by #11613
Closed

The thread created by the thread pool lacks the auto-increment serial number #11612

zhongqishang opened this issue Jan 9, 2024 · 1 comment · Fixed by #11613
Labels
status/need feedback

Comments

@zhongqishang
Copy link
Contributor

Is your feature request related to a problem? Please describe.

There are multiple threads in the thread pool. Without the auto-increment ID, it cannot be determined whether it is a thread pool, which is not conducive to troubleshooting problems.

"com.alibaba.nacos.client.Worker" Id=8536 WAITING on 
   ...

Describe the solution you'd like
Unified use of NameThreadFactory to create thread pools.

Describe alternatives you've considered
None

Additional context
None
zhongqishang added a commit to zhongqishang/nacos that referenced this issue Jan 9, 2024
@zhongqishang
[ISSUE alibaba#11612] Unified use of NameThreadFactory to create th…
b7865a7 
…read pools.
@zhongqishang zhongqishang mentioned this issue Jan 9, 2024
Merged
5 tasks
zhongqishang added a commit to zhongqishang/nacos that referenced this issue Jan 9, 2024
@zhongqishang
[ISSUE alibaba#11612] Unified use of NameThreadFactory to create th…
de1fac2 
…read pools.
@KomachiSion
Copy link
Collaborator

  1. this thread is fix size and only one thread for each client.
  2. your pr fix can't fix this problem, the NameThreadFactory id generator from 0 for each new NameThreadFactory.

KomachiSion pushed a commit that referenced this issue Jan 17, 2024
@zhongqishang
[ISSUE #11612] Unified use of NameThreadFactory to create thread po…
0716809 
…ols. (#11613)
Bo-Qiu pushed a commit to Bo-Qiu/nacos that referenced this issue Jan 19, 2024
@zhongqishang @Bo-Qiu
[ISSUE alibaba#11612] Unified use of NameThreadFactory to create th…
18ba642 
…read pools. (alibaba#11613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/need feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #11612] Unified use of NameThreadFactory to create thread pools zhongqishang/nacos
2 participants
@zhongqishang @KomachiSion