Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default tps control plugin is invalid #11573

Closed
godhth opened this issue Dec 28, 2023 · 1 comment · Fixed by #11579
Closed

The default tps control plugin is invalid #11573

godhth opened this issue Dec 28, 2023 · 1 comment · Fixed by #11579
Assignees
Labels
kind/bug Category issues or prs related to bug. plugin
Milestone

Comments

@godhth
Copy link
Contributor

godhth commented Dec 28, 2023

Describe the bug
按照官网文档配置完成之后,默认反脆弱插件tps限流不生效
After the configuration is complete, the default anti-vulnerability plug-in tps traffic limiting does not take effect

mkdir -p ${nacos.home}/data/tps/
echo '{"pointName":"ConfigQuery","pointRule":{"maxCount":100,"monitorType":"intercept"}}' > ${nacos.home}/data/tps/ConfigQuery

发现默认实现中都是返回成功,没有做实际限流逻辑
Found that the code is all returned success, no actual stream limiting logic
0880c4c807108db7c019

Expected behavior
A clear and concise description of what you expected to happen.

Actually behavior
A clear and concise description of what you actually to happen.

How to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See errors

Desktop (please complete the following information):

  • OS: [e.g. Centos]
  • Version [e.g. nacos-server 1.3.1, nacos-client 1.3.1]
  • Module [e.g. naming/config]
  • SDK [e.g. original, spring-cloud-alibaba-nacos, dubbo]

Additional context
Add any other context about the problem here.

@godhth
Copy link
Contributor Author

godhth commented Dec 28, 2023

@i will solve it@

@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. plugin labels Dec 29, 2023
@KomachiSion KomachiSion added this to the 2.3.1 milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants