Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check server stream ready state to avoid bytebuffer back up in flow control pending write queue. #11514

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

shiyiyue1102
Copy link
Collaborator

@shiyiyue1102 shiyiyue1102 commented Dec 15, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

1.check server stream ready state to avoid byte buffer back up in flow control pending write queue.
2. fix config module unit test cases failures and fix some bugs related the failed unit test cases.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Merging #11514 (732fd9a) into develop (bb7a6ce) will increase coverage by 0.07%.
Report is 17 commits behind head on develop.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11514      +/-   ##
=============================================
+ Coverage      61.63%   61.70%   +0.07%     
- Complexity      6826     6858      +32     
=============================================
  Files           1060     1066       +6     
  Lines          31408    31645     +237     
  Branches        3250     3257       +7     
=============================================
+ Hits           19358    19528     +170     
- Misses         10701    10765      +64     
- Partials        1349     1352       +3     
Files Coverage Δ
.../plugin/datasource/mapper/GroupCapacityMapper.java 100.00% <100.00%> (ø)
.../com/alibaba/nacos/core/remote/ConnectionMeta.java 50.81% <90.00%> (+7.68%) ⬆️
...cos/core/remote/NacosRuntimeConnectionEjector.java 33.73% <66.66%> (-1.64%) ⬇️
...alibaba/nacos/core/remote/grpc/GrpcConnection.java 73.33% <88.09%> (+39.40%) ⬆️

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7a6ce...732fd9a. Read the comment docs.

@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. kind/feature type/feature labels Dec 15, 2023
@KomachiSion KomachiSion added this to the 2.3.1 milestone Dec 15, 2023
@KomachiSion KomachiSion merged commit 06edd12 into alibaba:develop Dec 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos Core kind/enhancement Category issues or prs related to enhancement. kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants