-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strings in the query-suggestions and recent-searches plugins cannot be translated without replacing entire template #1282
Comments
That's a good point. Would you be willing to add a translations option as is the case for core? It was originally introduced in #581 for reference |
Sure. Would you prefer one PR for both plugins or a separate PR per plugin? |
One PR with tests for both plugins will be sufficient, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
While autocomplete-js allows for the submit/clear button strings to be localized externally, there are strings in the query-suggestions and recent-searches plugins that cannot be localized.
recent-searches
query-suggestions
Reproduction
There's not really a way to reproduce this cleanly since it is a gap in the API of these plugins.
Expected behavior
Plugins should allow for localized strings to be provided.
Environment
The text was updated successfully, but these errors were encountered: