Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): improve Composition Client searchResponse specs (matches SearchClient more closely for IS) #4300

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

e-krebs
Copy link
Contributor

@e-krebs e-krebs commented Jan 3, 2025

🧭 What and Why

Matching InstantSearch searchResponse types more closely

Changes included:

  • pagination information is required
  • query & params where missing (+required)
  • results is required

… SearchClient more closely for IS)
@e-krebs e-krebs self-assigned this Jan 3, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 3, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 3e138fe2a919d6bdebfaacd08677f45f46e058db
🍃 Generated commit 217cba5a96337db6e55c6224b92a1f2e3c6c733a
🌲 Generated branch generated/fix/composition-search-spec

@e-krebs e-krebs marked this pull request as ready for review January 3, 2025 16:14
@e-krebs e-krebs requested a review from a team as a code owner January 3, 2025 16:14
@e-krebs e-krebs requested review from Fluf22 and millotp January 3, 2025 16:14
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! Can I merge this directly ?

@e-krebs
Copy link
Contributor Author

e-krebs commented Jan 3, 2025

thanks ! Can I merge this directly ?

@millotp yes !
and publish it as soon as you want

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!! will release once on main

@shortcuts shortcuts enabled auto-merge (squash) January 6, 2025 11:01
@shortcuts shortcuts merged commit 784e40a into main Jan 6, 2025
12 checks passed
@shortcuts shortcuts deleted the fix/composition-search-spec branch January 6, 2025 11:10
algolia-bot added a commit that referenced this pull request Jan 6, 2025
… SearchClient more closely for IS) (#4300) (generated) [skip ci]

Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 6, 2025
… SearchClient more closely for IS) (generated)

algolia/api-clients-automation#4300

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants