feat(javascript): add worker build
#4249
Merged
+226
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Co-authored-by: Torbjørn Holtmon <torbjornholtmon@gmail.com>
millotp
reviewed
Dec 16, 2024
| } | ||
|
|
||
| {{#searchHelpers}} | ||
| async function getCryptoKey(secret: string): Promise<CryptoKey> { |
There was a problem hiding this comment.
no need to import CryptoKey ?
millotp
approved these changes
Dec 16, 2024
algolia-bot
added a commit
that referenced
this pull request
Dec 16, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com> Co-authored-by: Torbjørn Holtmon <torbjornholtmon@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Dec 16, 2024
algolia/api-clients-automation#4249 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com> Co-authored-by: Torbjørn Holtmon <torbjornholtmon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3318
Changes included:
follow up of algolia/algoliasearch-client-javascript#1573
closes algolia/algoliasearch-client-javascript#1567
adding a new build adds some overhead on the maintenance/build time of the client but for good, it prevents breaking the
generateSecuredApiKeysignature and allows us to still keep afetchbuild as well as aworkerbuildthe update of the package.json is a breaking change however, since it changes the imported build, but since it wasn't working... kind of a fix