Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(widgets): support $$widgetType metadata #950

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented May 16, 2022

Summary

This PR adds a $$widgetType property on all widgets to help identify them.

Ticket: FX-992

Result

  • all widgets have a $$widgetType property
  • the existence and the value of this property is tested

@dhayab dhayab requested review from a team, FabienMotte and sarahdayan and removed request for a team May 16, 2022 10:36
@netlify
Copy link

netlify bot commented May 16, 2022

Deploy Preview for angular-instantsearch ready!

Name Link
🔨 Latest commit b0c28cd
🔍 Latest deploy log https://app.netlify.com/sites/angular-instantsearch/deploys/62822909a57959000968017c
😎 Deploy Preview https://deploy-preview-950--angular-instantsearch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dhayab dhayab changed the title feat(widgets): support $$widgetType metadata feat(widgets): support $$widgetType metadata May 16, 2022
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a breaking change and correctly tested 👌

@dhayab dhayab merged commit 4565c06 into master May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants