Fix compilation errors #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johan-bjareholt
commented
Mar 22, 2024
•
johan-bjareholt
commented
- Fix compilation error introduced in 4602c65
- Fix general clippy errors (introduced in new version of clippy?)
- Fix unused field in struct
johan-bjareholt
changed the title
johan-bjareholt
force-pushed
the
compilation-error
branch
from
2d0bd14
to
56cdb7f
Compare
5 tasks
johan-bjareholt
force-pushed
the
compilation-error
branch
from
56cdb7f
to
12b2e34
Compare
johan-bjareholt
commented
Mar 22, 2024
| @@ -682,7 +682,7 @@ impl AgentBuilder { | |||
|
|
|||
| #[cfg(feature = "tls")] | |||
| #[derive(Clone)] | |||
| pub(crate) struct TLSClientConfig(pub(crate) Arc<rustls::ClientConfig>); | |||
| pub(crate) struct TLSClientConfig(()); | |||
There was a problem hiding this comment.
What's the point of this struct at all?
There was a problem hiding this comment.
It's not keeping something alive no?
algesten
approved these changes
Mar 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.