Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an option to configure lock file permissions #17

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat: add an option to configure lock file permissions #17

merged 3 commits into from
Jan 11, 2024

Conversation

sk91
Copy link
Contributor

@sk91 sk91 commented Nov 7, 2022

  • create file dir recursively if does not exist
  • allow configuring fd permissions (unix only)

alexflint
alexflint reviewed Nov 7, 2022
View reviewed changes
Copy link
Owner

@alexflint alexflint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thanks for submitting. One change requested.

filemutex_flock.go Outdated Show resolved Hide resolved
@sk91 sk91 requested a review from alexflint November 9, 2022 12:15
alexflint
alexflint reviewed Nov 9, 2022
View reviewed changes
Copy link
Owner

@alexflint alexflint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One further comment after thinking about this a little more. Thanks again @sk91 for putting this pr in.

filemutex_flock.go Outdated Show resolved Hide resolved
@alexflint alexflint merged commit 27556bd into alexflint:master Jan 11, 2024
@alexflint alexflint mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexflint alexflint alexflint left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sk91 @alexflint