Make it compile with wasm32-unknown-emscripten #397
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan:
|
Thanks! Would you be up to adding an entry in the CI matrix to compile for emscripten? I'm not sure how to do that myself. If you're not sure though that seems reasonable to leave out too. |
|
I'm working on that on a separate branch and will follow up with that later (it's not super easy, but have something hacky working) |
|
Ok! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that emscripten works. Now you can do:
And it works. Unlike the other WASM target, emscripten configures itself to work with both
unixandwasm, so we have to avoid the unix branch.A more recent variant of the patch in #301. For that PR, it was suggested that cfg_if would be a reasonable alternative. I'm happy to go that route if you want, but found that it makes things more complicated (to my eye). But maintainers choice.