Number overflow

[wholegroup]

Hi,

get-folder-size/index.js

Lines 59 to 61 in f5c7a3f

	const stats = returnType.strict ? await fs.lstat(itemPath) : await fs.lstat(itemPath).catch(error => errors.push(error));
	if(typeof stats !== 'object') return;
	fileSizes.set(stats.ino, stats.size);

We've got an issue with folder size calculation. We found out that stats.ino can be a BigInt when fs.lstat has additional options parameter.
I have 2 different files, one has ino = 57420895249767887n, the other has ino = 57420895249767888n
But after we cast BigInt to Number we could have the same result for 2 different values.
Number(57420895249767887n) is equal to 57420895249767890
and
Number(57420895249767888n) is equal to 57420895249767890 as well

Well, we have wrong size (results can be various because of Promise.all) if we call fs.lstat without {bigint: true} option.

Our current workaround:

  const patchedFs = {...fs};
  patchedFs.lstat = async function (itemPath) {
    const stats = await fs.lstat(itemPath, { bigint: true });
    stats.ino = stats.ino.toString();
    stats.size = Number(stats.size);
    return stats;
  };

  const { size, errors } = await getFolderSize(folder, {
    ignore: /node_modules/,
    fs: patchedFs
  });

[atjn]

Huh, I wasn't aware there was an issue with the conversion of ino IDs.

[atjn]

Thank you for documenting this properly and bringing it to our attention!

We should be releasing a fix for it soon :)