Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify disableESTransforms by default in Jest plugin #754

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

alangpierce
Copy link
Owner

Sucrase's ES transforms are pretty much never relevant when working in Node these days, and the Jest plugin is getting a semver-major release, so this changes the default to disable the ES transforms.

Verified

This commit was signed with the committer’s verified signature.
juliosueiras Julio Sueiras
Sucrase's ES transforms are pretty much never relevant when working in Node
these days, and the Jest plugin is getting a semver-major release, so this
changes the default to disable the ES transforms.
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #754 (c3dae7f) into main (e147008) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files          55       55           
  Lines        5887     5887           
  Branches     1394     1394           
=======================================
  Hits         5152     5152           
  Misses        466      466           
  Partials      269      269           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Benchmark results

Before this PR: 332.1 thousand lines per second
After this PR: 330.8 thousand lines per second

Measured change: 0.37% slower (0.68% slower to 0.02% faster)
Summary: Likely no significant difference

@alangpierce alangpierce merged commit 029da38 into main Oct 7, 2022
@alangpierce alangpierce deleted the disable-es-transforms-in-jest-plugin branch October 7, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant