Preserve imports when needed in Jest integration #752
Merged
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #741 When Jest is run with ESM enabled, it passes in either `supportsDynamicImport` or `supportsStaticESM` depending on whether the code is targeting ESM or CJS. The integration now configures Sucrase accordingly, which should be enough for the integration to just work with an ESM Jest configuration.
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 55 55
Lines 5887 5887
Branches 1394 1394
=======================================
Hits 5152 5152
Misses 466 466
Partials 269 269 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 323.6 thousand lines per second Measured change: 3.69% slower (4.56% slower to 1.14% slower) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741
When Jest is run with ESM enabled, it passes in either
supportsDynamicImportorsupportsStaticESMdepending on whether the code is targeting ESM or CJS. The integration now configures Sucrase accordingly, which should be enough for the integration to just work with an ESM Jest configuration.