Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - createManifestValidator failing because schemastore.org is returning 503 #183

Merged
merged 1 commit into from Mar 5, 2024
Merged

FIX - createManifestValidator failing because schemastore.org is returning 503 #183

merged 1 commit into from Mar 5, 2024

Conversation

ssf01
Copy link
Contributor

@ssf01 ssf01 commented Mar 5, 2024

In the last two days builds time out due to the issue with the website https://json.schemastore.org.

I propose updating the SCHEMA_URL from its current https://json.schemastore.org/chrome-manifest URL to the raw GitHub content URL https://raw.githubusercontent.com/SchemaStore/schemastore/master/src/schemas/json/chrome-manifest.json. GitHub has superior availability and it's a smaller change that we will encounter this issue again.

...
vite v5.1.0 building for development...
✓ 1 modules transformed.
dist/src/index.css  26.42 kB │ gzip: 4.85 kB
✓ built in 186ms
undefined:1
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">
^

SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON
    at JSON.parse (<anonymous>)
    at IncomingMessage.<anonymous> (file:///path/to/project/node_modules/.pnpm/vite-plugin-web-extension@4.1.1/node_modules/vite-plugin-web-extension/dist/index.js:949:20)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1696:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

Node.js v20.11.0

Fixes #182 .

aaronklinker-st
aaronklinker-st approved these changes Mar 5, 2024
View reviewed changes
Copy link

@aaronklinker-st aaronklinker-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure github is well known for their reliability lol, but maybe it's better. I'd rather we try catch the fetch request and skip on error. But I think this is fine for a quick fix.

@aklinker1 aklinker1 merged commit a84dfd7 into aklinker1:main Mar 5, 2024
2 checks passed
aklinker1 pushed a commit that referenced this pull request Mar 5, 2024
@ssf01 @aklinker1
fix: createManifestValidator failing because schemastore.org is retur…
5b07c2f 
…ning 503 (#183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aklinker1 aklinker1 aklinker1 approved these changes

@aaronklinker-st aaronklinker-st aaronklinker-st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when json.schemastore.org responds with HTTP Error
3 participants
@ssf01 @aklinker1 @aaronklinker-st