Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slickPrev not working after refresh starting v0.27.9 #2315

Closed
digitalartcrew opened this issue Dec 20, 2023 · 4 comments
Closed

slickPrev not working after refresh starting v0.27.9 #2315

digitalartcrew opened this issue Dec 20, 2023 · 4 comments

Comments

@digitalartcrew
Copy link

digitalartcrew commented Dec 20, 2023

Issue

Starting version v0.27.9 slickPrev stop working after refresh. targetSlide values becomes -1 instead of previous slide index. See below:

The screenshots demonstrate a change slide action starting from index 3 in both versions.

Not working as of 0.27.9
0 27 9-slickPrev-after-refresh

Working 0.27.8 and below
0 27 8-slickPrev-after-refresh

It looks like there is a bug here, regardless if lazyload is true/false it will also be overwritten when infinite is false
Screenshot 2023-12-20 at 1 13 54 PM

This code was also added when version failed git diff 69348c1 a43f109
Screenshot 2023-12-20 at 4 14 37 PM

@digitalartcrew
Copy link
Author

@akiran Would you mind taking a look at this issue? Thanks

@akiran
Copy link
Owner

akiran commented Jan 25, 2024

This could be because of unnecessary re-renders of Slider when state in a parent component changes.

I am working on a fix and I will make a release soon
#2331

@akiran
Copy link
Owner

akiran commented Jan 25, 2024

@digitalartcrew Can you give a code sample to replicate the issue you are facing?

akiran added a commit that referenced this issue Jan 26, 2024
@akiran akiran closed this as completed in 9d96291 Jan 26, 2024
akiran added a commit that referenced this issue Jan 26, 2024
@digitalartcrew
Copy link
Author

This could be because of unnecessary re-renders of Slider when state in a parent component changes.

I am working on a fix and I will make a release soon #2331

Thank you very much. It looks like this issue is resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants