🧪 Collect Cython coverage in CI

[webknjaz]

$sbj.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (777acc9) 99.74% compared to head (1a126c6) 97.82%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   99.74%   97.82%   -1.92%     
==========================================
  Files           4        5       +1     
  Lines         772     1012     +240     
  Branches      219      219              
==========================================
+ Hits          770      990     +220     
- Misses          2       22      +20     

Flag	Coverage Δ
unit	97.72% <ø> (-1.89%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[webknjaz]

@mjpieters @Dreamsorcerer does the change note sound comprehensive enough? https://yarl--961.org.readthedocs.build/en/961/changes/#contributor-facing-changes

[Dreamsorcerer]

Yep, nice.

[webknjaz]

PyPy is failing because coveragepy loads the cython plugin and emits a warning: nedbat/coveragepy#1702. I think I'll just stick a sed in there...

[webknjaz]

Postponing merging since Coverage.py is unable to map non-editable install lines to the source: it reports 0 lines and 100% coverage. Need to investigate.

[Dreamsorcerer]

While I have your attention, are you happy with adding bdraco to committers?
aio-libs/aiohttp#7865 (comment)

[webknjaz]

While I have your attention, are you happy with adding bdraco to committers? aio-libs/aiohttp#7865 (comment)

Yeah, I meant to respond. Sorry. I'm all for it! Could you make a separate issue for transparency, though? Maybe, tag some active folks across the org? @mjpieters somes to mind. Here are the previous examples: https://github.com/aio-libs/aiohttp/issues?q=is%3Aissue+sort%3Aupdated-desc+Nominate.

[webknjaz]

Apparently, I forgot to pass the same cython directives to the bare cython call as I set in the build backend.

[webknjaz]

FTR this change revealed that parts of the tests aren't being executed.