Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax test_leak to run reliable against free-threaded python #1060

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Mar 16, 2025

Free-threaded Python has a little different GC implementation, the number in the test should be raised.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Mar 16, 2025
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #1060 will degrade performances by 9.8%

Comparing relax (40add31) with master (fe4dee0)

Summary

❌ 1 (👁 1) regressions
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_multidict_extend_str 168.8 µs 187.1 µs -9.8%

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (fe4dee0) to head (40add31).
Report is 1 commits behind head on master.

❌ Your project status has failed because the head coverage (86.53%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          22       22           
  Lines        2597     2597           
  Branches      376      376           
=======================================
  Hits         2533     2533           
  Misses         36       36           
  Partials       28       28           
Flag Coverage Δ
CI-GHA 97.53% <100.00%> (ø)
MyPy 86.53% <100.00%> (ø)
pytest 98.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov merged commit 4cb2f08 into master Mar 16, 2025
44 of 47 checks passed
@asvetlov asvetlov deleted the relax branch March 16, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant