Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __contains__ with unexpected types #1045

Merged
merged 8 commits into from
Feb 18, 2025
Merged

Conversation

Dreamsorcerer
Copy link
Member

Found this while adding inline type annotations for mypy.

Copy link

codspeed-hq bot commented Feb 16, 2025

CodSpeed Performance Report

Merging #1045 will degrade performances by 17.92%

Comparing Dreamsorcerer-patch-1 (0045914) with master (25618eb)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cimultidict_extend_istr 108.5 µs 132.2 µs -17.92%

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 16, 2025
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
@Dreamsorcerer Dreamsorcerer merged commit b4d5c55 into master Feb 18, 2025
37 of 42 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-1 branch February 18, 2025 01:23
@Dreamsorcerer Dreamsorcerer mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants