Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9454/b20908e backport][3.10] Simplify DNS throttle implementation #9457

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 10, 2024

(cherry picked from commit b20908e)

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
(cherry picked from commit b20908e)

Unverified

The committer email address is not verified.
…event loop needed as we got rid of a task
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 10, 2024
@bdraco bdraco changed the title Simplify DNS throttle implementation (#9454) [PR #9454/b20908e backport][3.10] Simplify DNS throttle implementation Oct 10, 2024
@bdraco bdraco marked this pull request as ready for review October 10, 2024 17:22
@bdraco bdraco enabled auto-merge (squash) October 10, 2024 17:22
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (ee87a04) to head (ef87aab).
Report is 90 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9457   +/-   ##
=======================================
  Coverage   97.81%   97.82%           
=======================================
  Files         108      106    -2     
  Lines       34986    35046   +60     
  Branches     4191     4216   +25     
=======================================
+ Hits        34221    34282   +61     
+ Misses        569      568    -1     
  Partials      196      196           
Flag Coverage Δ
CI-GHA 97.70% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.39% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.93% <100.00%> (+0.01%) ⬆️
OS-macOS 97.09% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.94% <100.00%> (+0.01%) ⬆️
Py-3.10.15 96.88% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.96% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.43% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.41% <100.00%> (+0.01%) ⬆️
Py-3.8.10 94.31% <100.00%> (+0.01%) ⬆️
Py-3.8.18 96.68% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.80% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.40% <100.00%> (+<0.01%) ⬆️
VM-macos 97.09% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.39% <100.00%> (+<0.01%) ⬆️
VM-windows 94.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit cdf3dca into 3.10 Oct 10, 2024
36 of 37 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/b20908e531ff349545cff5e90de24975bc27afda/pr-9454 branch October 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant