Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create marker for internal tests #8299

Merged
merged 6 commits into from Apr 7, 2024
Merged

Create marker for internal tests #8299

merged 6 commits into from Apr 7, 2024

Conversation

Dreamsorcerer
Copy link
Member

To help avoid issues with downstream packagers etc. we should disable a few tests for them which are dependent on the CI environment.

@Dreamsorcerer Dreamsorcerer added backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Apr 5, 2024
@Dreamsorcerer
Copy link
Member Author

Some of the tests in test_websocket_writer.py are a good candidate to add to this later, as the binary tests depend on the version of zlib installed. However, some new tests should also be added that test the cleartext as well, so there are still tests for packagers to run. I'll leave this as a future exercise.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 5, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (88c80c1) to head (3a83c32).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8299   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         107      107           
  Lines       33024    33025    +1     
  Branches     3872     3874    +2     
=======================================
+ Hits        32191    32192    +1     
  Misses        609      609           
  Partials      224      224
Flag Coverage Δ
CI-GHA 97.40% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.06% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.61% <100.00%> (+0.05%) ⬆️
OS-macOS 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.46% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.92% <100.00%> (+0.02%) ⬆️
Py-3.11.8 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 97.24% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.39% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.43% <100.00%> (?)
Py-3.9.19 96.89% <100.00%> (+0.09%) ⬆️
VM-macos 96.83% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.06% <100.00%> (+<0.01%) ⬆️
VM-windows 95.61% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member Author

Well, that's not what I intended... :P

@Dreamsorcerer
Copy link
Member Author

Dreamsorcerer commented Apr 5, 2024 •
edited

I'm not sure if pytest has an option that simply cancels out the -m 'not internal'. The only option appears to be to run only the tests marked internal...

bdraco
bdraco reviewed Apr 5, 2024
View reviewed changes
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Apr 5, 2024
View reviewed changes
CHANGES/8299.packaging.rst Outdated Show resolved Hide resolved
CHANGES/8299.packaging.rst Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
Dreamsorcerer
Dreamsorcerer commented Apr 5, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
Dreamsorcerer and others added 3 commits April 5, 2024 22:43
@Dreamsorcerer @bdraco @webknjaz
Apply suggestions from code review
3145f95 
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
@Dreamsorcerer
Update 8299.packaging.rst
785b731
@Dreamsorcerer
Merge branch 'master' into pytest-internal-marker
3a83c32
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) April 7, 2024 21:02
@Dreamsorcerer Dreamsorcerer merged commit 28d026e into master Apr 7, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the pytest-internal-marker branch April 7, 2024 22:10
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 7, 2024 •
edited

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/28d026eb9d0c93389431f8f142a5f7c4448d13f9/pr-8299

Backported as #8307

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 7, 2024
@Dreamsorcerer @patchback
Create marker for internal tests (#8299)
73d0901 
To help avoid issues with downstream packagers etc. we should disable a
few tests for them which are dependent on the CI environment.

(cherry picked from commit 28d026e)
@patchback patchback bot mentioned this pull request Apr 7, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 7, 2024 •
edited

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/28d026eb9d0c93389431f8f142a5f7c4448d13f9/pr-8299

Backported as #8308

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 7, 2024
@Dreamsorcerer @patchback
Create marker for internal tests (#8299)
89e2ecc 
To help avoid issues with downstream packagers etc. we should disable a
few tests for them which are dependent on the CI environment.

(cherry picked from commit 28d026e)
@patchback patchback bot mentioned this pull request Apr 7, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Apr 7, 2024
@patchback @Dreamsorcerer
[PR #8299/28d026eb backport][3.10] Create marker for internal tests (#…
7853b08 
…8308)

**This is a backport of PR #8299 as merged into master
(28d026e).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Apr 7, 2024
@patchback @Dreamsorcerer
[PR #8299/28d026eb backport][3.9] Create marker for internal tests (#…
ec2be05 
…8307)

**This is a backport of PR #8299 as merged into master
(28d026e).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dreamsorcerer @webknjaz @bdraco