Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow arbitrary sequence types in version (#7835) #7836

Conversation

Dreamsorcerer
Copy link
Member

(cherry picked from commit 1e86b77)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 1e86b77)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb94533) 97.35% compared to head (36cd97a) 97.35%.
Report is 2 commits behind head on 3.9.

Files Patch % Lines
aiohttp/resolver.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              3.9    #7836   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files         107      107           
  Lines       32357    32362    +5     
  Branches     3836     3837    +1     
=======================================
+ Hits        31501    31506    +5     
  Misses        652      652           
  Partials      204      204           
Flag Coverage Δ
CI-GHA 97.26% <95.00%> (+<0.01%) ⬆️
OS-Linux 96.95% <95.00%> (+<0.01%) ⬆️
OS-Windows 94.49% <95.00%> (+<0.01%) ⬆️
OS-macOS 96.61% <95.00%> (+<0.01%) ⬆️
Py-3.10.11 94.40% <95.00%> (+<0.01%) ⬆️
Py-3.10.13 96.78% <95.00%> (-0.01%) ⬇️
Py-3.11.6 96.45% <95.00%> (-0.01%) ⬇️
Py-3.8.10 94.38% <95.00%> (+<0.01%) ⬆️
Py-3.8.18 96.71% <95.00%> (+<0.01%) ⬆️
Py-3.9.13 94.39% <95.00%> (+<0.01%) ⬆️
Py-3.9.18 96.76% <95.00%> (-0.01%) ⬇️
Py-pypy7.3.13 96.22% <95.00%> (+<0.01%) ⬆️
VM-macos 96.61% <95.00%> (+<0.01%) ⬆️
VM-ubuntu 96.95% <95.00%> (+<0.01%) ⬆️
VM-windows 94.49% <95.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 53476df into 3.9 Nov 13, 2023
25 of 31 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/1e86b777e61cf4eefc7d92fa57fa19dcc676013b/pr-7835 branch November 13, 2023 22:36
xiangxli pushed a commit to xiangxli/aiohttp that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant