Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CookieJar - return 'best-match' and not LIFO (#7577) #7588

Conversation

Dreamsorcerer
Copy link
Member

Co-authored-by: marq24 marq24@emac.de
(cherry picked from commit 9c932f7)

Co-authored-by: marq24 <marq24@emac.de>
(cherry picked from commit 9c932f7)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 7, 2023
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) September 7, 2023 16:14
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #7588 (17de494) into 3.8 (8c4ec62) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##              3.8    #7588    +/-   ##
========================================
  Coverage   97.36%   97.37%            
========================================
  Files         107      107            
  Lines       31039    31056    +17     
  Branches     3251     3937   +686     
========================================
+ Hits        30222    30241    +19     
+ Misses        611      610     -1     
+ Partials      206      205     -1     
Flag Coverage Δ
CI-GHA 97.24% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.89% <100.00%> (+0.01%) ⬆️
OS-Windows 95.21% <100.00%> (+0.07%) ⬆️
OS-macOS 96.62% <100.00%> (+0.04%) ⬆️
Py-3.10.11 94.82% <100.00%> (+<0.01%) ⬆️
Py-3.10.12 ?
Py-3.10.13 96.53% <100.00%> (?)
Py-3.11.0 96.16% <100.00%> (?)
Py-3.6.15 96.36% <100.00%> (-0.02%) ⬇️
Py-3.6.8 94.74% <100.00%> (+<0.01%) ⬆️
Py-3.7.17 96.52% <100.00%> (+<0.01%) ⬆️
Py-3.7.9 94.87% <100.00%> (?)
Py-3.8.10 94.80% <100.00%> (?)
Py-3.8.17 ?
Py-3.8.18 96.42% <100.00%> (?)
Py-3.9.13 94.79% <100.00%> (?)
Py-3.9.17 ?
Py-3.9.18 96.49% <100.00%> (?)
Py-pypy7.3.11 93.88% <100.00%> (?)
VM-macos-latest 96.62% <100.00%> (+0.04%) ⬆️
VM-ubuntu-20.04 96.87% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 96.38% <100.00%> (?)
VM-windows-latest 95.21% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiohttp/cookiejar.py 98.83% <100.00%> (ø)
tests/test_cookiejar.py 99.12% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit 5946c74 into 3.8 Sep 7, 2023
32 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.8/9c932f71ec5a450954cee92ff9450974414ac1d8/pr-7577 branch September 7, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants