Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7333/3a54d378 backport][3.8] Fix TLS transport is None error #7357

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jul 9, 2023

This is a backport of PR #7333 as merged into master (3a54d37).

Fixes #3355

The type has been fixed in typeshed as well, so the bug here would be highlighted in mypy 1.5+.
python/typeshed#10346 (comment)

Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
(cherry picked from commit 3a54d37)
@patchback patchback bot requested a review from asvetlov as a code owner July 9, 2023 00:58
@webknjaz webknjaz enabled auto-merge (squash) July 9, 2023 01:04
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #7357 (dbd76ab) into 3.8 (4087410) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.8    #7357      +/-   ##
==========================================
- Coverage   97.39%   97.39%   -0.01%     
==========================================
  Files         107      107              
  Lines       30996    30999       +3     
  Branches     3924     3925       +1     
==========================================
+ Hits        30188    30190       +2     
- Misses        604      605       +1     
  Partials      204      204              
Flag Coverage Δ
CI-GHA 97.25% <0.00%> (-0.01%) ⬇️
OS-Linux 96.89% <0.00%> (-0.01%) ⬇️
OS-Windows 95.22% <0.00%> (-0.02%) ⬇️
OS-macOS 96.64% <0.00%> (+<0.01%) ⬆️
Py-3.10.11 94.83% <0.00%> (-0.02%) ⬇️
Py-3.10.12 96.53% <0.00%> (+<0.01%) ⬆️
Py-3.11.0 96.20% <0.00%> (-0.01%) ⬇️
Py-3.6.15 96.37% <0.00%> (+<0.01%) ⬆️
Py-3.6.8 94.75% <0.00%> (-0.02%) ⬇️
Py-3.7.17 96.52% <0.00%> (-0.01%) ⬇️
Py-3.7.9 94.88% <0.00%> (-0.01%) ⬇️
Py-3.8.10 94.80% <0.00%> (-0.01%) ⬇️
Py-3.8.17 96.48% <0.00%> (+0.04%) ⬆️
Py-3.9.13 94.81% <0.00%> (-0.01%) ⬇️
Py-3.9.17 96.45% <0.00%> (-0.01%) ⬇️
Py-pypy7.3.11 93.94% <0.00%> (-0.01%) ⬇️
VM-macos-latest 96.64% <0.00%> (+<0.01%) ⬆️
VM-ubuntu-20.04 96.88% <0.00%> (-0.01%) ⬇️
VM-ubuntu-latest 96.42% <0.00%> (-0.01%) ⬇️
VM-windows-latest 95.22% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/connector.py 93.26% <0.00%> (-0.40%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz merged commit 8d45f9c into 3.8 Jul 9, 2023
31 of 34 checks passed
@webknjaz webknjaz deleted the patchback/backports/3.8/3a54d3785e4b314ca70aaafbee5b3ae8d409c18e/pr-7333 branch July 9, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants