Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10552/44e669be backport][3.11] Cache parsing of the content-type #10557

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Mar 15, 2025

This is a backport of PR #10552 as merged into master (44e669b).

What do these changes do?

When profiling some frequent POST requests, I found the bulk of the time was spent parsing the content-type string. Use the same strategy as we do for parse_mimetype to cache the parsing.

Are there changes in behavior for the user?

performance improvement

Is it a substantial burden for the maintainers to support this?

no

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Screenshot 2025-03-15 at 11 25 10 AM

Sorry, something went wrong.

(cherry picked from commit 44e669b)
@patchback patchback bot requested review from webknjaz and asvetlov as code owners March 15, 2025 22:56
@patchback patchback bot mentioned this pull request Mar 15, 2025
5 tasks
@bdraco bdraco enabled auto-merge (squash) March 15, 2025 22:57
Copy link

codspeed-hq bot commented Mar 15, 2025

CodSpeed Performance Report

Merging #10557 will improve performances by 16.25%

Comparing patchback/backports/3.11/44e669be1ab1a60c40183f92f172670d912cb834/pr-10552 (3863906) with 3.11 (7205661)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_one_hundred_json_post_requests[pyloop] 44.9 ms 38.6 ms +16.25%

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (7205661) to head (3863906).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11   #10557   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         123      123           
  Lines       37370    37376    +6     
  Branches     4509     4510    +1     
=======================================
+ Hits        36656    36662    +6     
  Misses        538      538           
  Partials      176      176           
Flag Coverage Δ
CI-GHA 97.97% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.68% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.72% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.81% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.67% <100.00%> (+<0.01%) ⬆️
Py-3.10.16 97.23% <100.00%> (+0.03%) ⬆️
Py-3.11.11 97.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.74% <100.00%> (+<0.01%) ⬆️
Py-3.12.9 97.74% <100.00%> (+<0.01%) ⬆️
Py-3.13.2 97.74% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.58% <100.00%> (+<0.01%) ⬆️
Py-3.9.21 97.14% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.72% <100.00%> (+0.01%) ⬆️
VM-macos 96.81% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.68% <100.00%> (+<0.01%) ⬆️
VM-windows 94.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 928e6d7 into 3.11 Mar 15, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/44e669be1ab1a60c40183f92f172670d912cb834/pr-10552 branch March 15, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant