Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for JSON post requests that check the content type #10553

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 15, 2025

What do these changes do?

Add benchmark for JSON post requests that check the content type

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

Verified

This commit was signed with the committer’s verified signature.
wyattjoh Wyatt Johnson
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Mar 15, 2025
Copy link

codspeed-hq bot commented Mar 15, 2025

CodSpeed Performance Report

Merging #10553 will not alter performance

Comparing json_post_benchmarks (3a8724f) with master (e507ba3)

Summary

✅ 46 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_one_hundred_json_post_requests[pyloop] N/A 44.6 ms N/A

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (e507ba3) to head (3a8724f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10553   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files         122      122           
  Lines       37230    37246   +16     
  Branches     2064     2065    +1     
=======================================
+ Hits        36745    36761   +16     
  Misses        338      338           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.57% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.24% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.18% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.26% <100.00%> (+<0.01%) ⬆️
Py-3.10.16 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.11 97.89% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.35% <100.00%> (-0.01%) ⬇️
Py-3.12.9 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.13.2 98.34% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.9.21 97.68% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 87.81% <100.00%> (-0.02%) ⬇️
VM-macos 97.36% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.24% <100.00%> (+<0.01%) ⬆️
VM-windows 96.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review March 15, 2025 21:59
@bdraco bdraco requested a review from asvetlov as a code owner March 15, 2025 21:59
@bdraco bdraco enabled auto-merge (squash) March 15, 2025 21:59
@bdraco bdraco merged commit 55c5f1f into master Mar 15, 2025
43 checks passed
@bdraco bdraco deleted the json_post_benchmarks branch March 15, 2025 22:01
Copy link
Contributor

patchback bot commented Mar 15, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/55c5f1fc16e61f576f05d31c1f9bbd324943729c/pr-10553

Backported as #10554

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 15, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
)

(cherry picked from commit 55c5f1f)
Copy link
Contributor

patchback bot commented Mar 15, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/55c5f1fc16e61f576f05d31c1f9bbd324943729c/pr-10553

Backported as #10555

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 15, 2025
)

(cherry picked from commit 55c5f1f)
bdraco added a commit that referenced this pull request Mar 15, 2025
…sts that check the content type (#10554)

**This is a backport of PR #10553 as merged into master
(55c5f1f).**

<!-- Thank you for your contribution! -->

## What do these changes do?

Add benchmark for JSON post requests that check the content type

## Are there changes in behavior for the user?

no

## Is it a substantial burden for the maintainers to support this?
no

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Mar 15, 2025
…sts that check the content type (#10555)

**This is a backport of PR #10553 as merged into master
(55c5f1f).**

<!-- Thank you for your contribution! -->

## What do these changes do?

Add benchmark for JSON post requests that check the content type

## Are there changes in behavior for the user?

no

## Is it a substantial burden for the maintainers to support this?
no

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant