Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runs-on for wheel builds for native arm #10410

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 5, 2025

-latest was being appended to everything but this will not work with the native arm runners

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
-latest was being appended to everything but this will not work
with the native arm runners
@bdraco bdraco requested a review from webknjaz as a code owner February 5, 2025 21:29
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Feb 5, 2025
@bdraco bdraco enabled auto-merge (squash) February 5, 2025 21:31
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (6ee81df) to head (c3d7b10).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10410      +/-   ##
==========================================
+ Coverage   97.31%   98.76%   +1.45%     
==========================================
  Files         120      122       +2     
  Lines       37057    37125      +68     
  Branches     2033     2044      +11     
==========================================
+ Hits        36061    36666     +605     
+ Misses        813      319     -494     
+ Partials      183      140      -43     
Flag Coverage Δ
CI-GHA 98.65% <ø> (+1.35%) ⬆️
OS-Linux 98.33% <ø> (?)
OS-Windows 96.25% <ø> (?)
OS-macOS 97.45% <ø> (+0.16%) ⬆️
Py-3.10.11 97.34% <ø> (?)
Py-3.10.16 97.91% <ø> (?)
Py-3.11.11 98.00% <ø> (?)
Py-3.11.9 97.42% <ø> (+0.30%) ⬆️
Py-3.12.8 98.43% <ø> (+1.19%) ⬆️
Py-3.13.1 98.42% <ø> (?)
Py-3.9.13 97.23% <ø> (?)
Py-3.9.21 97.79% <ø> (?)
Py-pypy7.3.16 97.38% <ø> (?)
VM-macos 97.45% <ø> (+0.16%) ⬆️
VM-ubuntu 98.33% <ø> (?)
VM-windows 96.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #10410 will not alter performance

Comparing fix_os_tag_wheel_builds (c3d7b10) with master (9b33be3)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco merged commit 1009c06 into master Feb 5, 2025
40 checks passed
@bdraco bdraco deleted the fix_os_tag_wheel_builds branch February 5, 2025 21:40
Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/1009c066dc88de1360bfb1d011cd0cc9addeb534/pr-10410

Backported as #10411

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 5, 2025
(cherry picked from commit 1009c06)
Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/1009c066dc88de1360bfb1d011cd0cc9addeb534/pr-10410

Backported as #10412

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 5, 2025
(cherry picked from commit 1009c06)
bdraco added a commit that referenced this pull request Feb 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…native arm (#10411)

**This is a backport of PR #10410 as merged into master
(1009c06).**

-latest was being appended to everything but this will not work with the
native arm runners

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Feb 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…native arm (#10412)

**This is a backport of PR #10410 as merged into master
(1009c06).**

-latest was being appended to everything but this will not work with the
native arm runners

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant