Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable wheel builds on PyPy #10403

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Disable wheel builds on PyPy #10403

merged 1 commit into from
Feb 5, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 5, 2025

fixes failure seen in https://github.com/aio-libs/aiohttp/actions/runs/13165870727

When I split these, I forgot to turn these off as we have never tried to build extensions on PyPy

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
@bdraco bdraco requested a review from webknjaz as a code owner February 5, 2025 20:45
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (9b33be3) to head (f2a8f83).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10403      +/-   ##
==========================================
+ Coverage   98.74%   98.76%   +0.01%     
==========================================
  Files         122      122              
  Lines       37125    37125              
  Branches     2044     2044              
==========================================
+ Hits        36659    36666       +7     
+ Misses        323      319       -4     
+ Partials      143      140       -3     
Flag Coverage Δ
CI-GHA 98.65% <ø> (+0.01%) ⬆️
OS-Linux 98.33% <ø> (+0.01%) ⬆️
OS-Windows 96.25% <ø> (ø)
OS-macOS 97.44% <ø> (-0.01%) ⬇️
Py-3.10.11 95.83% <ø> (-1.51%) ⬇️
Py-3.10.16 97.91% <ø> (ø)
Py-3.11.11 98.00% <ø> (ø)
Py-3.11.9 95.92% <ø> (-1.51%) ⬇️
Py-3.12.8 98.41% <ø> (-0.03%) ⬇️
Py-3.13.1 98.42% <ø> (ø)
Py-3.9.13 97.23% <ø> (-0.01%) ⬇️
Py-3.9.21 97.79% <ø> (ø)
Py-pypy7.3.16 97.38% <ø> (?)
VM-macos 97.44% <ø> (-0.01%) ⬇️
VM-ubuntu 98.33% <ø> (+0.01%) ⬆️
VM-windows 96.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #10403 will not alter performance

Comparing disable_wheel_builds_pypy (f2a8f83) with master (9b33be3)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco enabled auto-merge (squash) February 5, 2025 20:51
@bdraco bdraco merged commit 908145c into master Feb 5, 2025
41 checks passed
@bdraco bdraco deleted the disable_wheel_builds_pypy branch February 5, 2025 20:57
Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/908145c97546afb717807d3bcad1f63110fdaa4a/pr-10403

Backported as #10405

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 5, 2025
(cherry picked from commit 908145c)
Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/908145c97546afb717807d3bcad1f63110fdaa4a/pr-10403

Backported as #10406

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 5, 2025
(cherry picked from commit 908145c)
bdraco added a commit that referenced this pull request Feb 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
)

**This is a backport of PR #10403 as merged into master
(908145c).**

fixes failure seen in
https://github.com/aio-libs/aiohttp/actions/runs/13165870727

When I split these, I forgot to turn these off as we have never tried to
build extensions on PyPy

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Feb 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
)

**This is a backport of PR #10403 as merged into master
(908145c).**

fixes failure seen in
https://github.com/aio-libs/aiohttp/actions/runs/13165870727

When I split these, I forgot to turn these off as we have never tried to
build extensions on PyPy

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant