Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to native arm runners for wheel builds #10396

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 5, 2025

Not a user facing change as we should get the same wheels in the end, however it should build a bit faster since its using native runners and musl is now split up

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
No functional change, otherwise that it should build a bit faster
since its split up some more
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Feb 5, 2025
@bdraco bdraco marked this pull request as ready for review February 5, 2025 19:23
@bdraco bdraco requested a review from webknjaz as a code owner February 5, 2025 19:23
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #10396 will not alter performance

Comparing use_native_arm_builds (dc6dea7) with master (9057364)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (9057364) to head (dc6dea7).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10396   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files         122      122           
  Lines       37125    37125           
  Branches     2044     2044           
=======================================
  Hits        36666    36666           
  Misses        319      319           
  Partials      140      140           
Flag Coverage Δ
CI-GHA 98.65% <ø> (ø)
OS-Linux 98.33% <ø> (ø)
OS-Windows 96.25% <ø> (ø)
OS-macOS 97.45% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.34% <ø> (-0.01%) ⬇️
Py-3.10.16 97.91% <ø> (ø)
Py-3.11.11 98.00% <ø> (ø)
Py-3.11.9 97.43% <ø> (+<0.01%) ⬆️
Py-3.12.8 98.43% <ø> (ø)
Py-3.13.1 98.42% <ø> (ø)
Py-3.9.13 97.23% <ø> (-0.01%) ⬇️
Py-3.9.21 97.79% <ø> (ø)
Py-pypy7.3.16 97.37% <ø> (-0.01%) ⬇️
VM-macos 97.45% <ø> (+<0.01%) ⬆️
VM-ubuntu 98.33% <ø> (ø)
VM-windows 96.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 481a837 into master Feb 5, 2025
43 checks passed
@bdraco bdraco deleted the use_native_arm_builds branch February 5, 2025 19:33
Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/481a8374a6fa7b75269f6e523348b2ce7cb498b6/pr-10396

Backported as #10398

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 5, 2025
(cherry picked from commit 481a837)
Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/481a8374a6fa7b75269f6e523348b2ce7cb498b6/pr-10396

Backported as #10399

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 5, 2025
(cherry picked from commit 481a837)
bdraco added a commit that referenced this pull request Feb 5, 2025

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
…wheel builds (#10398)

**This is a backport of PR #10396 as merged into master
(481a837).**

Not a user facing change as we should get the same wheels in the end,
however it should build a bit faster since its using native runners and
musl is now split up

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Feb 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…wheel builds (#10399)

**This is a backport of PR #10396 as merged into master
(481a837).**

Not a user facing change as we should get the same wheels in the end,
however it should build a bit faster since its using native runners and
musl is now split up

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant