Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve TypeError on import for Python < 3.9.2 #151

Merged
merged 6 commits into from
Mar 12, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 12, 2025

#150 shows we have a problem with Python < 3.9.2

This is because of a bug in cpython that was not fixed until 3.9.2 python/cpython#87131

fixes #150

bdraco added 2 commits March 11, 2025 15:06

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b23d919) to head (dc297f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          250       249    -1     
  Branches        53        53           
=========================================
- Hits           250       249    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
@bdraco bdraco changed the title chore: add Python 3.9.1 to the CI fix: resolve TypeError on import for Python older than 3.9.2 Mar 12, 2025

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
@bdraco bdraco changed the title fix: resolve TypeError on import for Python older than 3.9.2 fix: resolve TypeError on import for Python 3.9.1 Mar 12, 2025
@bdraco bdraco changed the title fix: resolve TypeError on import for Python 3.9.1 fix: resolve TypeError on import for Python < 3.9.2 Mar 12, 2025
bdraco and others added 2 commits March 11, 2025 15:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bdraco bdraco marked this pull request as ready for review March 12, 2025 01:37
@pre-commit-ci pre-commit-ci bot deployed to test_release March 12, 2025 01:37 Active
@bdraco bdraco merged commit 2042c82 into main Mar 12, 2025
24 of 25 checks passed
@bdraco bdraco deleted the python_391 branch March 12, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import fails with Python 3.9.0 and Python 3.9.1 (works with Python 3.9.2+)
1 participant