Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise EndOfStream from None in MemoryObjectReceiveStream.receive() #889

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

agronholm
Copy link
Owner

Changes

Changes EndOfStream to be raised from None to avoid AttributeError: 'MemoryObjectItemReceiver' object has no attribute 'item' to be included in the traceback, leading many to think this is a bug when in fact it was only an implementation detail.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/anyio/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

Sorry, something went wrong.

@agronholm agronholm merged commit d134da7 into master Mar 16, 2025
17 checks passed
@agronholm agronholm deleted the endofstream-chained branch March 16, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants