Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed documentation on providing custom typed attributes #683

Merged
merged 2 commits into from Feb 3, 2024
Merged

Fixed documentation on providing custom typed attributes #683

merged 2 commits into from Feb 3, 2024

Conversation

agronholm
Copy link
Owner

This section was not up to date.

ejm4567
ejm4567 approved these changes Feb 1, 2024
View reviewed changes
Copy link

@ejm4567 ejm4567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the import in docs/typedattrs.rst to omit TypedAttribute, as well as the other changes should do the trick to fix the documentation.

Thanks!

@agronholm
Copy link
Owner Author

Changing the import in docs/typedattrs.rst to omit TypedAttribute, as well as the other changes should do the trick to fix the documentation.

Thanks!

Just to clarify, do you feel there's something still missing after this PR?

@ejm4567
Copy link

ejm4567 commented Feb 2, 2024

I think the changes in the PR should do it.

@agronholm agronholm merged commit 137de70 into master Feb 3, 2024
16 checks passed
@agronholm agronholm deleted the fix-typedattr-docs branch February 3, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejm4567 ejm4567 ejm4567 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agronholm @ejm4567