Shade check issue with L2 filters

[ProtonBruno]

Hi team,
We are using shade check in a pipeline job to validate policy changes.
It's a bit broken when dealing with L2 Juniper filters (Bridge or Ethernet Switching):
If you add for example an allow ARP ether-type term then shade check will report any following term as shaded by this one even if it specifies another protocol.

term allow-arp { ether-type:: arp counter:: allow-arp action:: accept } term allow-icmp { source-address:: MGMT_DHCP destination-address:: INFRA protocol:: icmp icmp-type:: echo-request counter:: allow-icmp action:: accept } term allow-https { source-address:: MGMT_INFRA_SRV destination-address:: INFRA_MS protocol:: tcp destination-port:: HTTPS counter:: allow-https action:: accept } term default-deny { logging:: syslog counter:: default-deny action:: deny }

Specifying ether-type in following terms is currently not possible:
<class 'aerleon.lib.policy.TermProtocolEtherTypeError'>ether-type not supported when used with upper-layer protocol restrictions. Term: allow-https

Thanks

[ankenyr]

Hey @ProtonBruno thanks for the report here. Yea shade checking has some janky to it. We should be able to fix the above unless you wish to take a stab at it?