Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password requirements #377

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

password requirements #377

wants to merge 6 commits into from

Conversation

BLEMENT33
Copy link
Contributor

@BLEMENT33 BLEMENT33 commented Mar 16, 2024

Description

update our password validators to unsure new users' password are strong enough.
We need to coordinate this with Titan.

Fix: #330

@BLEMENT33 BLEMENT33 linked an issue Mar 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.79%. Comparing base (f42bab6) to head (0e2d28f).

Files Patch % Lines
app/utils/validators.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   82.76%   82.79%   +0.02%     
==========================================
  Files          98       98              
  Lines        6086     6096      +10     
==========================================
+ Hits         5037     5047      +10     
  Misses       1049     1049              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some unit tests?

app/utils/validators.py Outdated Show resolved Hide resolved
app/utils/validators.py Outdated Show resolved Hide resolved
@armanddidierjean armanddidierjean added enhancement New feature or request core labels Mar 19, 2024
app/utils/validators.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set password requirements
2 participants