Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use integer cents in AMAP / Tombola #295

Open
Petitoto opened this issue Nov 16, 2023 · 0 comments · May be fixed by #366
Open

Use integer cents in AMAP / Tombola #295

Petitoto opened this issue Nov 16, 2023 · 0 comments · May be fixed by #366
Labels
amap bug Something isn't working

Comments

@Petitoto
Copy link
Member

Subject of the issue

In AMAP, we should use integers for money balance in AMAP or Tombola. We could avoid rounding errors.

Your environment

  • Version of Hyperion: latest main
  • Operating system: debian

Steps to reproduce

Create a balance in AMAP. Add money, create an order, and delete the order. Repet the operation if the issue does not occur.

Expected behaviour

We get the exact same money we added when creating the balance.

Actual behaviour

Some roundings errors can happen, which can lead to losing 0.000000...1€
@Petitoto Petitoto added the bug Something isn't working label Nov 16, 2023
@BLEMENT33 BLEMENT33 linked a pull request Mar 15, 2024 that will close this issue
Use integer cents in AMAP / Tombola #366
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amap bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use integer cents in AMAP / Tombola aeecleclair/Hyperion
2 participants
@Petitoto @armanddidierjean